[lkml]   [2004]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] add syscalls.h
    On Sun, Feb 01, 2004 at 10:43:44PM -0800, Andrew Morton wrote:
    > +extern asmlinkage long sys_unlink(const char __user *pathname);
    > +extern asmlinkage long sys_chmod(const char __user *filename, mode_t mode);
    > +extern asmlinkage long sys_fchmod(unsigned int fd, mode_t mode);
    > Maybe lose the `extern' too. It's just a waste of space. I normally put
    > it in for consistency if the surrounding code is done that way, but for a
    > new header file, why bother?

    I'd really like to see the extern go, if only to discourage that
    particular bit of cargo cult programming. There are actually people
    who think it serves a purpose..

    Matt Mackall : : Linux development and consulting
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:00    [W:0.020 / U:25.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site