Messages in this thread | | | Date | Sat, 28 Feb 2004 00:26:14 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH] iSeries virtual disk |
| |
On Fri, 27 Feb 2004 12:13:00 +0000 Christoph Hellwig <hch@infradead.org> wrote: > > That's not how I read your code. But to actually understand what it's > doing we need to know what open_data.max_disk actually is. > > is this the maximum number of disks currently configured (if so the > interface would be absolutely braindead, but the current code would > match your above description although beein rather confusing).
It is the highest index of all the configured disks. Did you read my previous email? If disks 1 2 4 and 7 are configured, the open_data.max_disk will be 7. If the admin thena adds disk 23, the next time we probe (by calling the HV open interface) the returned max_disk will be 23.
I do not apologise for braindead interfaces in code I didn't write ... In this case I just have to use it.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |