Messages in this thread | | | Subject | Re: Radeon Framebuffer Driver in 2.6.3? | From | Benjamin Herrenschmidt <> | Date | Sat, 28 Feb 2004 12:37:21 +1100 |
| |
> Rememeber we have to modify every driver then to support FB_ACTIVATE_FORCE. > You have to ask yourself what do you want to do exactly?
No we don't. Only fbmem, and that's part of the patch. What we could do is strip the FB_ACTIVATE_FORCE (and actually clear out the activate field completely) when copying to the driver's var structure in fb_set_var().
In fact, we should certainly fix fb_set_var to _ignore_ the activate field when comparing the var structures... this is a bug in the current version imho.
It's a bit difficult to fix it while keeping memcmp, except if we do a local copy of the var structure, which would eat stack space...
One problem with unblank is that it can be called at interrupt time, but I don't think that ever happens with mode_switch set to true. So we may just kmalloc a local copy of the var...
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |