lkml.org 
[lkml]   [2004]   [Feb]   [27]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 27 Feb 2004 18:00:49 +0000 (GMT)
FromJames Simmons <>
SubjectRe: Radeon Framebuffer Driver in 2.6.3?
> Can you test the patch below ? :

Just a couple of things. The idea of adding another field to 
con_blank bothers me. I think the better approach is to add more flags.

> ===== drivers/char/vt.c 1.61 vs edited =====
> --- 1.61/drivers/char/vt.c	Thu Feb 19 14:43:03 2004
> +++ edited/drivers/char/vt.c	Fri Feb 27 17:27:09 2004
> @@ -2743,12 +2743,12 @@
>       *  Called only if powerdown features are allowed.
>       */
>      switch (vesa_blank_mode) {
> -	case VESA_NO_BLANKING:
> -	    c->vc_sw->con_blank(c, VESA_VSYNC_SUSPEND+1);
> +    case VESA_NO_BLANKING:
> +	    c->vc_sw->con_blank(c, VESA_VSYNC_SUSPEND+1, 0);

> ===== drivers/video/fbmem.c 1.90 vs edited =====
> --- 1.90/drivers/video/fbmem.c	Mon Feb 16 23:42:15 2004
> +++ edited/drivers/video/fbmem.c	Fri Feb 27 17:25:21 2004
> @@ -943,7 +943,8 @@
>  {
>  	int err;
> 
> -	if (memcmp(&info->var, var, sizeof(struct fb_var_screeninfo))) {
> +	if ((var->activate & FB_ACTIVATE_FORCE) ||
> +	    memcmp(&info->var, var, sizeof(struct fb_var_screeninfo))) {
>  		if (!info->fbops->fb_check_var) {
>  			*var = info->var;
>  			return 0;

Ug!!! Another flag. How about instead in fbcon.c we call set_par directly 
instead of messing with fb_set_var. 

Let me play with some ideas. I can have a another patch ready over the 
weekend. 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.234 / U:0.110 seconds]
©2003-2008 Jasper Spaans