![]() | |||||||||||||
Messages in this thread |
Hi Jens,
On Thu, 26 Feb 2004 08:40:43 +0100 Jens Axboe <axboe@suse.de> wrote:
>
> On Thu, Feb 26 2004, Jeff Garzik wrote:
> > 4) why do you call blkdev_dequeue_request() in do_viodasd_request()
> > rather than viodasd_end_request() ? Or just use end_request() ?
>
> It makes the queueing simpler (you could potentially leave the _last_
> request on the queue, but it's probably not worth the hassle).
Thanks.
> They should not call elv_next_request() only to bail if
> num_req_outstanding is too big, since it has side effects (moving
> request from io scheduler core to dispatch, which makes it ineligible
> for merging, sorting, etc).
>
> do {
> if (too_many_queued)
> break;
>
> rq = elv_next_request(q);
> if (!rq)
> break;
>
> ...
> }
OK, fixed.
> > 12) don't you need to set blk_queue_max_phys_segments() too?
>
> Yep
Done.
New patch following soon ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature] | ||||||||||||
| Last update: 2005-03-22 13:01 [from the cache] ©2003-2008 | |||||||||||||