lkml.org 
[lkml]   [2004]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] Distributed mmap API
Daniel Phillips <phillips@arcor.de> wrote:
>
> On Wednesday 25 February 2004 17:07, Andrew Morton wrote:
> > Daniel Phillips <phillips@arcor.de> wrote:
> > > - pte = ptep_get_and_clear(ptep);
> > > + if (unlikely(!all) && is_anon(pfn_to_page(pfn)))
> > > + continue;
> > > + pte = ptep_get_and_clear(ptep); /* get dirty bit atomically */
> > > tlb_remove_tlb_entry(tlb, ptep, address+offset);
> > > if (pfn_valid(pfn)) {
> >
> > I think you need to check pfn_valid() before running is_anon(pfn_to_page())
>
> Easy enough:
>
> if (unlikely(!all) && pfn_valid(pfn) && is_anon(pfn_to_page(pfn)))

You can probably factor this into

page = NULL;
if (pfn_valid(..))
page = pfn_to_page(..)
if (page)
..
if (page)
..

> but how can we legitimately get !pfn_valid there?

A mapping of some I/O region?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.129 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site