lkml.org 
[lkml]   [2004]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: Bug#234631: kernel-source-2.6.3: kernel fails to compile : radeon_setup_i2c_bus etc.
From
On Wed, Feb 25, 2004 at 09:03:19PM +0100, Olivier Berger wrote:
>
> >> Never mind, I've found the problem. RADEON is selecting I2C_ALGOBIT
> >> but as kconfig currently does not propagate selects up the dependency
> >> chain (that is according to Roman), this can leave I2C as m while
> >> I2C_ALGOBIT is y.
> >>
> >> This patch fixes it by explicitly selecting I2C.
> >
> > That seems to solve the problem.
> >
>
> Hmm... having checked again, there are some warnings left after make
> menuconfig execution though :
>
> rms:/usr/src/kernel-source-2.6.3# make menuconfig
> make[1]: `scripts/fixdep' is up to date.
> scripts/kconfig/mconf arch/i386/Kconfig
> Warning! Found recursive dependency: I2C FB_MATROX_I2C I2C I2C_ELV

OK, this patch should get rid of those warnings by removing the now
redundant dependency of FB_RADEON_I2C on I2C. Also, since FB_MATROX_I2C
is a tristate, we can move the select back to it.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: kernel-2.5/drivers/video/Kconfig
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/video/Kconfig,v
retrieving revision 1.11
diff -u -r1.11 Kconfig
--- kernel-2.5/drivers/video/Kconfig 19 Feb 2004 09:55:58 -0000 1.11
+++ kernel-2.5/drivers/video/Kconfig 25 Feb 2004 20:30:42 -0000
@@ -462,7 +462,6 @@
config FB_MATROX
tristate "Matrox acceleration"
depends on FB && PCI
- select I2C_ALGOBIT if FB_MATROX_I2C
---help---
Say Y here if you have a Matrox Millennium, Matrox Millennium II,
Matrox Mystique, Matrox Mystique 220, Matrox Productiva G100, Matrox
@@ -550,6 +549,7 @@
config FB_MATROX_I2C
tristate "Matrox I2C support"
depends on FB_MATROX && I2C
+ select I2C_ALGOBIT
---help---
This drivers creates I2C buses which are needed for accessing the
DDC (I2C) bus present on all Matroxes, an I2C bus which
@@ -628,6 +628,7 @@
tristate "ATI Radeon display support"
depends on FB && PCI
select I2C_ALGOBIT if FB_RADEON_I2C
+ select I2C if FB_RADEON_I2C
help
Choose this option if you want to use an ATI Radeon graphics card as
a framebuffer device. There are both PCI and AGP versions. You
@@ -645,7 +646,7 @@

config FB_RADEON_I2C
bool "DDC/I2C for ATI Radeon support"
- depends on FB_RADEON && I2C
+ depends on FB_RADEON
default y
help
Say Y here if you want DDC/I2C support for your Radeon board.
\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.030 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site