Messages in this thread | | | Date | Tue, 24 Feb 2004 16:57:25 -0700 | From | Tom Rini <> | Subject | Re: Split kgdb into "lite" and "normal" parts |
| |
On Wed, Feb 25, 2004 at 12:49:41AM +0100, Pavel Machek wrote: > Hi! > > > > > > > > Tested (core-lite.patch + i386-lite.patch + 8250.patch) combination. > > > > > > > Looks good. > > > > > > > > > > > > > > Let's first check this in and then do more cleanups. > > > > > > > Tom, does it sound ok? > > > > > > > > > > > > This sounds fine to me. Pavel, I'm guessing you did this with quilt, > > > > > > could you provide some pointers on how to replicate this in the future? > > > > > > > > > > Unfortunately, I done it by hand :-(. But if -lite parts are not > > > > > merged, soon, I'll be forced to start using quilt. Doing stuff by hand > > > > > is quite painfull... > > > > > > > > There's still a whole bunch of bogons in the -lite patch still, so I > > > > don't think it should be merged yet. > > > > > > Well, it seems to contains a *lot* less bogons than what currently is > > > in -mm series. > > > > > > What big problems do you see? It does not yet use weak symbols, but I > > > do not think that's a serious problem. What else? > > > > The first two big ones are: > > - Doesn't like gdb 6.0 (You cannot assume the first packet is Hc...) > > - Wierdities with kgdb_killed_or_detached / kgdb_might_be_resumed > > (both can die). > > - Issues w/ handling 'D' and 'k' packets cleaner (and I think there was > > a correctness fix in there, too, but it was a while ago). > > - Don't ACK packets sitting on the line > > Okay, these look important but probably only touch core-lite, right?
Some of these also touch 8250/kgdboe patch.
> So it should be easy to merge. Can you generate diff?
I'm working on that part right now, along with a cosmetic rename / Lindent the code.
> I'll try to import kgdb into quilt to make working with it > easier. [But don't expect miracles.]
Just let us know what it takes to do so. :)
> > - All of the function pointer games (of which the weak symbols, but not > > all of them) are a part of. > > - kgdb_schedule/process_breakpoint, required for kgdboe, harmless to use > > on serial. > > > > There's still a lot of stuff I checked into linux-2.6-kgdb that's > > non-trivially important > > (http://ppc.bkbits.net:8080/linux-2.6-kgdb/ChangeSet@-4w?nav=index.html) > > Hmm, I'm not allowed to use bt :-(.
You can look at it all via the web 'tho. There's nothing to agree to, to view the web page :)
-- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |