lkml.org 
[lkml]   [2004]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Please back out the bluetooth sysfs support
    From
    Date
    Hi Dave,

    > > > > > - skb->dev = (void *) &bfusb->hdev;
    > > > > > + skb->dev = (void *) bfusb->hdev;
    > > > >
    > > > > Wait a bloody minute. skb->dev is supposed to be net_device; what's going
    > > > > on here?
    > > >
    > > > Oh yeah, this is busted.
    > > > I'm surprised this doesn't explode.
    > >
    > > we used this from the beginning and I don't see where this can explode,
    > > because the SKB's are only used inside the Bluetooth subsystem.
    >
    > Ok, if that is %100 true, then it's OK.

    I went through the code to check it and we only use skb->dev between the
    HCI driver and the HCI core layer. All layers above are clean.

    Regards

    Marcel


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:01    [W:0.019 / U:33.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site