lkml.org 
[lkml]   [2004]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arch-specific callout in panic()
Date
Mike Strosaker <strosake@austin.ibm.com> wrote:
>@@ -53,7 +53,8 @@
> static char buf[1024];
> va_list args;
> #if defined(CONFIG_ARCH_S390)
>- unsigned long caller = (unsigned long) __builtin_return_address(0);
>+ extern unsigned long panic_caller;
>+ panic_caller = (unsigned long) __builtin_return_address(0);
> #endif
>
> bust_spinlocks(1);
...
>+ machine_panic();
>+

Why don't you just pass __builtin_return_address(0) to machine_panic for
everyone? It will get you rid of the #ifdef completely and the argument
can still be ignored.
Also, arch_panic() might be a little clearer than machine_panic().

Arnd <><

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site