Messages in this thread | | | Subject | Re: fb_console_init fix. | From | Benjamin Herrenschmidt <> | Date | Sat, 21 Feb 2004 09:56:56 +1100 |
| |
On Sat, 2004-02-21 at 08:58, James Simmons wrote: > Hi! > > This patch fixes fb_console_init from being called twice. I still need > to fix set_con2fb but this helps but this is still important to get in.
I hate those #ifdef MODULE. They are plaguing the drivers too, because of our crazy initialization scheme...
(Linus: that patch should still go in, doing better is probably a 2.7 target in this case).
If we want the fb stuff to be initialized before other drivers, we probably want to create an init step before devices and after PCI probe, but is that really necessary ?
The core fbdev should just need a subsys initcall. fbcon could use that too and register a notifier. Then we could use the notifier mecanism to notify fbcon when fbdev's are added (from register_framebuffer) and get rid of all of the init crap
The only remaining junk is to deal with the setup= stuff, but then, it could be done by having the drivers provide their "name" string & setup function in the ops structure passed on register, and have us call back the driver straight away, though that's a big change of the way drivers are initialized.
Or we could add an fb_check_setup("name", my_driver_setup) call to be done by the drivers before register_framebuffer is called
Ben .
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |