lkml.org 
[lkml]   [2004]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 18 Feb 2004 22:40:20 -0500
FromJeff Garzik <>
SubjectRe: dm core patches
Mike Christie wrote:
> diff -aurp linux-2.6.3-orig/include/linux/errno.h linux-2.6.3-ec/include/linux/errno.h
> --- linux-2.6.3-orig/include/linux/errno.h 2004-02-17 19:59:12.000000000 -0800
> +++ linux-2.6.3-ec/include/linux/errno.h 2004-02-18 12:45:42.000000000 -0800
> @@ -23,6 +23,14 @@
> #define EJUKEBOX 528 /* Request initiated, but will not complete before timeout */
> #define EIOCBQUEUED 529 /* iocb queued, will get completion event */
>
> +/* Block device error codes */
> +#define EFATALDEV 540 /* Fatal device error */
> +#define EFATALTRNSPT 541 /* Fatal transport error */
> +#define EFATALDRV 542 /* Fatal driver error */
> +#define ERETRYDEV 543 /* Device error occured, I/O may be retried */
> +#define ERETRYTRNSPT 544 /* Transport error occured, I/O may be retried */
> +#define ERETRYDRV 545 /* Driver error occured, I/O may be retried */


I'm not sure errno is the best place... I would rather define them in
blkdev.h and prefix them such that it's obvious they are specific to
block devices.

Also, WRT the I/O error printk, you probably want to print out a string
representing the error value returned... that info is available now,
might as well tell the user about it.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [from the cache]
©2003-2010