Messages in this thread | | | Date | Wed, 18 Feb 2004 01:54:23 +0000 | From | Matthew Wilcox <> | Subject | Re: radeon warning on 64-bit platforms |
| |
On Tue, Feb 17, 2004 at 04:51:24PM -0800, David Mosberger wrote: > >>>>> On Wed, 18 Feb 2004 10:48:49 +1100, Anton Blanchard <anton@samba.org> said: > > Anton> A small thing, could the comment be constrained to 80 > Anton> columns? :) > > I don't really see the point of that, given that pretty much all > existing Linux source code is formatted for 100 columns. I don't feel > strongly about it, however, so I changed it.
Um, only your crap. Everybody else follows Documentation/CodingStyle. This is mentioned in a couple of places:
Now, some people will claim that having 8-character indentations makes the code move too far to the right, and makes it hard to read on a 80-character terminal screen. The answer to that is that if you need more than 3 levels of indentation, you're screwed anyway, and should fix your program.
...
Functions should be short and sweet, and do just one thing. They should fit on one or two screenfuls of text (the ISO/ANSI screen size is 80x24, as we all know), and do one thing and do that well.
I wish the ia64 code weren't indented to 100 columns. It's why I hate working with your code.
-- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |