lkml.org 
[lkml]   [2004]   [Feb]   [17]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromRusty Russell <>
SubjectRe: kthread, signals and PF_FREEZE (suspend)
DateTue, 17 Feb 2004 15:44:18 +1100
In message <20040216165329.GB17323@mail.shareable.org> you write:
> Rusty Russell wrote:
> > > That means that signal_pending() will return true for that process which
> > > will make kthread stop the thread.
> > 
> > Yes, the way they are currently coded.  I had assumed that spurious
> > signals do not occur.
> 
> Yowch.  Does suspend mean this warning in futex_wait is wrong?
> 
> 	/* A spurious wakeup should never happen. */
> 	WARN_ON(!signal_pending(current));
> 	return -EINTR;

That's why it's a WARN_ON not a BUG_ON, and why suspend is
experimental.  But the bug reports we've seen didn't mention "I was
suspending when..."

Although Dirk has CONFIG_SOFTWARE_SUSPEND=y.

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:01    [from the cache]
©2003-2008