![]() | |||||||||||||
Messages in this thread |
On Mon, 16 Feb 2004, Andrew Morton wrote: > > This saves a goto. It works, but I wasn't able to trigger > the oops without it either. To trigger the bug you have to have _just_ the right memory usage, I suspect. You literally have to have the destination page directory allocation unmap the _exact_ source page (which has to be clean) for the bug to hit. So I suspect the oops only triggers on the machine that the trigger program was written for. Your version of the patch saves a goto in the source, but results in an extra goto in the generated assembly unless the compiler is clever enough to notice the double test for NULL. Never mind, that's a micro-optimization, and your version is cleaner. Let's go with it if Rajesh can verify that it fixes the problem for him. Rajesh? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:01 [W:0.490 / U:0.020 seconds] ©2003-2008 Jasper Spaans | |||||||||||||