Messages in this thread | | | Date | Fri, 13 Feb 2004 12:59:36 -0800 | From | Greg KH <> | Subject | Re: [PATCH] don't allow / in class device names |
| |
On Fri, Feb 13, 2004 at 12:45:55PM -0800, Stephen Hemminger wrote: > > No, the "fix" is to just not do this in the driver. I'm not going to > > apply this patch, sorry. > > > > thanks, > > > > greg k-h > > Bah, kernel API's should check there arguments. One of my peeve's about sysfs is > that it is far too lazy about checking it's inputs. Especially, when the restrictions > are not well documented, the code needs to validate.
But isn't a '/' character a valid character for a file or directory name? :)
Yeah, it's pathalogical, but why burden the core from something that is instantly obvious to the developer as a "wrong" thing to do?
It's much easier to see, "Oh, my driver created a stupid directory name because of the string I told it to use", than "why in the world is the driver core rejecting my register call when I _know_ it's a correct structure".
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |