[lkml]   [2004]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] don't allow / in class device names
    On Fri, Feb 13, 2004 at 12:45:55PM -0800, Stephen Hemminger wrote:
    > > No, the "fix" is to just not do this in the driver. I'm not going to
    > > apply this patch, sorry.
    > >
    > > thanks,
    > >
    > > greg k-h
    > Bah, kernel API's should check there arguments. One of my peeve's about sysfs is
    > that it is far too lazy about checking it's inputs. Especially, when the restrictions
    > are not well documented, the code needs to validate.

    But isn't a '/' character a valid character for a file or directory
    name? :)

    Yeah, it's pathalogical, but why burden the core from something that is
    instantly obvious to the developer as a "wrong" thing to do?

    It's much easier to see, "Oh, my driver created a stupid directory name
    because of the string I told it to use", than "why in the world is the
    driver core rejecting my register call when I _know_ it's a correct


    greg k-h
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:00    [W:0.019 / U:14.596 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site