![]() | |||||||||||||
Messages in this thread |
Alex Pankratov <ap@swapped.cc> writes: > Stephen Hemminger wrote: > > +++ linux-2.6.2.hlist/lib/list.c 2004-02-10 13:03:08.000000000 -0800 > > > >> @@ -0,0 +1,10 @@ > >> +#include <linux/module.h> > >> +#include <linux/list.h> > >> + > >> +/* > >> + * shared tail sentinel for hlists > >> + */ > >> +struct hlist_node hlist_null; > > Could this be const? > > No, because its 'pprev' field *is* getting modified. I didn't notice this before, sorry. But this could end up being a scalability problem on big SMP systems. Even though the cache line of this is never read it will bounce all the time between all CPUs using hlists and add considerably latency and cross node traffic. Remember Linux is supposed to run well on 128 CPU machines now. Maybe you can make it UP only, but I'm still not sure it's worth it. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 14:00 [from the cache] ©2003-2008 | |||||||||||||