Messages in this thread | | | Subject | Re: [patch 2/3] whitespace cleanups in fs/cifs/file.c | Date | Wed, 29 Dec 2004 13:31:26 -0300 | From | Horst von Brand <> |
| |
=?iso-8859-1?Q?J=F6rn?= Engel <joern@wohnheim.fh-wedel.de> said: > On Wed, 29 December 2004 10:42:40 -0300, Horst von Brand wrote: > > Jesper Juhl <juhl-lkml@dif.dk> said: > > > On Wed, 29 Dec 2004, Jörn Engel wrote: > > > > On Wed, 29 December 2004 00:52:32 +0100, Jesper Juhl wrote: > > > > > - if(file->private_data != NULL) { > > > > > + if (file->private_data != NULL) { > > > > > > > > if (file->private_data) { > > > > > > > > It's a question of taste, but in most cases I consider the shorter > > > > version to be more obvious. > > > > > > > Yeah, matter of personal preference, but since both styles are used in the > > > file I had to pick one of them to try and make it consistent - I simply > > > picked my personally prefered form. > > > > Nope. See Documentation/CodingStyle (it implicitly agrees with you, BTW). > > Can you be more specific? Did you mean the "if (x is true) {" part?
That, and NULL is mentioned only in a == NULL construction. -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |