Messages in this thread | | | Date | Mon, 27 Dec 2004 18:21:34 +0100 | From | Jörn Engel <> | Subject | Re: [patch] remove unnessesary casts from drivers/mtd/maps/nettel.c and kill two warnings |
| |
On Sun, 26 December 2004 22:13:48 +0100, Jesper Juhl wrote: > > I took a look at the cause for these warnings in the 2.6.10 kernel, > > drivers/mtd/maps/nettel.c:361: warning: assignment makes pointer from integer without a cast > drivers/mtd/maps/nettel.c:395: warning: assignment makes pointer from integer without a cast > > and as far as I can see the casts in there (to unsigned long and back to > void*) are completely unnessesary ('virt' in 'struct map_info' is a void > __iomem *), and getting rid of those casts buys us a warning free build. > > Are there any reasons not to apply the patch below? > Unfortunately I don't have hardware to test this patch, so it has been > compile tested only.
Neither do I, but the patch looks fine to me. Give Greg a grace period, in case he knows better. And interpret this as a personal opinion, not as dwmw2's final word.
If it helps: Acked-by: Jörn Engel <joern@wh.fh-wedel.de>
Jörn
-- To recognize individual spam features you have to try to get into the mind of the spammer, and frankly I want to spend as little time inside the minds of spammers as possible. -- Paul Graham - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |