lkml.org 
[lkml]   [2004]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix inlining related build failures in mxser.c
    On Fri, 24 Dec 2004 14:54:43 +0100, Florian Weimer wrote:
    >* Jesper Juhl:
    >
    >>> Add -funit-at-a-time to the CFLAGS, and the compiler is happy.
    >>>
    >> But, does unit-at-a-time work reliably for all compilers on all archs back
    >> to and including gcc 2.95.3 ?
    >
    >Unit-at-a-time is only available in GCC 3.4 and above.

    The problem with unit-at-a-time isn't compiler availability,
    but the fact that at least with gcc-3.4 on x86 it causes
    significant stack usage increases, which in the kernel lead
    to stack overflow problems. This is not a theoretical issue,
    the overflows have been observed in normal kernels.

    So wrt inlining failures, the correct fix is to remove the
    inlines or rearrange the code to allow inlining w/o unit-at-a-time.

    /Mikael
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.020 / U:32.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site