Messages in this thread | | | Date | Mon, 20 Dec 2004 14:58:17 -0800 | From | Greg KH <> | Subject | Re: [PATCH] add PCI API to sysfs |
| |
On Mon, Dec 20, 2004 at 02:50:46PM -0800, Jesse Barnes wrote: > Ok, how does this one look? It needs some obvious work, but is the approach > of adding functionality to sysfs instead of /proc the right way to go? What > I've done: > > o add mmap support to bin files in sysfs > o make PCI resources available via mmap > o make legacy I/O and memory space available in sysfs
How about splitting this up into the different patches that each do one thing?
That way finding stuff like the following is easier:
> ===== fs/sysfs/bin.c 1.19 vs edited ===== > --- 1.19/fs/sysfs/bin.c 2004-11-01 12:46:46 -08:00 > +++ edited/fs/sysfs/bin.c 2004-12-20 11:07:58 -08:00 > @@ -92,6 +92,15 @@ > return count; > } > > +static int mmap(struct file *file, struct vm_area_struct *vma) > +{ > + struct dentry *dentry = file->f_dentry; > + struct bin_attribute *attr = to_bin_attr(dentry); > + struct kobject *kobj = to_kobj(dentry->d_parent); > + > + return attr->mmap(kobj, attr, vma); > +} > +
What happens if mmap is not set? oops...
also CC: to the sysfs and pci maintainer will jog his memory that he should be looking at these types of patches :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |