Messages in this thread |  | | | Date | Sun, 19 Dec 2004 13:36:07 +0000 | | From | Christoph Hellwig <> | | Subject | Re: [RFC] [PATCH] cdu31a - more fixes |
| |
> +#define RETURN_UP(retval) do {up(&sony_sem); return (retval);} while(0)
Please don't use such obsfucation macros. Instead use gotos in the functions to haev a single exit path that releases the lock.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |