lkml.org 
[lkml]   [2004]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ip2: fix compile warnings
On Fri, Dec 17, 2004 at 10:16:24PM -0500, Jim Nelson wrote:
>
> How about doing something like this:
>
> #ifdef ENABLE_DSSNOW
> #define DSSNOW_ENABLED 1
> #else
> #define DSSNOW_ENABLED 0
> #endif
>
> -blah-
>
> static int ip2_tiocmget(struct tty_struct *tty, struct file *file)
> {
> i2ChanStrPtr pCh = DevTable[tty->index];
>
> if (pCh == NULL)
> return -ENODEV;
>
> if (DSSNOW_ENABLED) {
> if (ip2_tiocmget_dssnow() == -EINTR) return -EINTR;
> }
>
> return ((pCh->dataSetOut & I2_RTS) ? TIOCM_RTS : 0)
> | ((pCh->dataSetOut & I2_DTR) ? TIOCM_DTR : 0)
> | ((pCh->dataSetIn & I2_DCD) ? TIOCM_CAR : 0)
> | ((pCh->dataSetIn & I2_RI) ? TIOCM_RNG : 0)
> | ((pCh->dataSetIn & I2_DSR) ? TIOCM_DSR : 0)
> | ((pCh->dataSetIn & I2_CTS) ? TIOCM_CTS : 0);
> }
>
> /*
> FIXME - the following code is causing a NULL pointer dereference in
> 2.3.51 in an interrupt handler. It's suppose to prompt the board
> to return the DSS signal status immediately. Why doesn't it do
> the same thing in 2.2.14?
> */
>
> /* This thing is still busted in the 1.2.12 driver on 2.4.x
> and even hoses the serial console so the oops can be trapped.
> /\/\|=mhw=|\/\/ */
>
> static int ip2_tiocmget_dssnow (void)
> {
>...

The real issue is the FIXME in the comment.

Such a patch would remove the warning but wouldn't fix the underlying
real issue.

Fixing warnings is usually not a bad idea, but in this case I'd say the
warning could stay until somebody fixes the real issue in the code.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site