Messages in this thread | | | Date | Sat, 18 Dec 2004 04:15:43 +0000 | From | Matthew Wilcox <> | Subject | Re: [KJ] [PATCH] lcd: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() |
| |
On Fri, Dec 17, 2004 at 05:59:05PM -0600, James Nelson wrote: > Remove the cli()/sti() calls in drivers/char/lcd.c
I'm not sure why anyone would bother ...
config COBALT_LCD bool "Support for Cobalt LCD" depends on MIPS_COBALT
those machines are never SMP.
However, looking at the driver, it doesn't seem to generate interrupts, so I don't see what good disabling interrupts would do. I think we can simply remove the save_flags/cli/restore_flags from this driver. It needs a fair chunk of work though -- should be converted to use writeb instead of
*((volatile unsigned char *) burn_addr) = (volatile unsigned char) rom[index];
-- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |