lkml.org 
[lkml]   [2004]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] Delete sysfs_dirent.s_count, saving ~100kB on my system
On Wed, Dec 01, 2004 at 03:51:59PM -0800, Chris Wright wrote:
> * Andrew Morton (akpm@osdl.org) wrote:
> > That's all well and good, but sysfs_new_dirent() should be using a
> > standalone slab cache for allocating sysfs_dirent instances. That way, we
> > use 36 bytes for each one rather than 64.
>
> Reasonable, here's a patch (lightly tested). Without, size-64 looks
> like so:
>
> size-64 4064 4108 76 52 1 : tunables 32 16 8 : slabdata 79 79 0 : globalstat 4263 4079 79 0 0 0 84 0 : cpustat 15986 337 12286 3
>
> And with:
>
> size-64 1196 1196 76 52 1 : tunables 32 16 8 : slabdata 23 23 0 : globalstat 1297 1196 23 0 0 0 84 0 : cpustat 12418 108 11349 1
> sysfs_dir_cache 2862 2916 48 81 1 : tunables 32 16 8 : slabdata 36 36 0 : globalstat 2931 2874 36 0 0 0 113 0 : cpustat 2756 216 110 0
>
>
> Allocate sysfs_dirent structures from their own slab.

Nice, thanks for doing this.

Applied,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.039 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site