Messages in this thread Patch in this message | | | Date | Thu, 16 Dec 2004 23:55:05 -0800 | From | Andrew Morton <> | Subject | Re: 2.6.10-rc3-mm1 |
| |
William Lee Irwin III <wli@holomorphy.com> wrote: > > William Lee Irwin III <wli@holomorphy.com> wrote: > >> This appears to have trouble on em64t; not only does the following happen, > >> but some odd userspace programs (e.g. ssh) appear to be failing. > >> > >> Shutting down powersaved cut here ] --------- [please bite here ] --------- > >> KDdoneernel BUG at pageattr:156 > > On Wed, Dec 15, 2004 at 03:42:39AM -0800, Andrew Morton wrote: > > I can't say I'm surprised, really, although it booted and did stuff OK on my > > box. > > There's a mangled-up mess of ioremap/pageattr patches from Andrea and Andi > > in there. I'll drop a few things. We need to go through those changes a > > little more carefully. > > The odd userspace programs failing are far more disturbing. They > suggest COW or something of similar gravity is broken on x86-64 > by some new patch. The ioremap/pageattr issues are merely some > shutdown-time oops, which is rather minor in comparison, although > reported far more verbosely.
Oh, I missed that. Did you apply the ioctl fix?
--- 25/fs/ioctl.c~ioctl-cleanups-broke-fionread-et-al 2004-12-13 11:12:37.687951760 -0800 +++ 25-akpm/fs/ioctl.c 2004-12-13 11:12:37.690951304 -0800 @@ -91,10 +91,8 @@ asmlinkage long sys_ioctl(unsigned int f int block; int res; - if (!S_ISREG(inode->i_mode)) { - error = -ENOTTY; - goto done; - } + if (!S_ISREG(inode->i_mode)) + break; /* do we support this mess? */ if (!mapping->a_ops->bmap) { error = -EINVAL; @@ -112,19 +110,15 @@ asmlinkage long sys_ioctl(unsigned int f goto done; } case FIGETBSZ: - if (!S_ISREG(inode->i_mode)) { - error = -ENOTTY; - goto done; - } + if (!S_ISREG(inode->i_mode)) + break; error = -EBADF; if (inode->i_sb) error = put_user(inode->i_sb->s_blocksize, p); goto done; case FIONREAD: - if (!S_ISREG(inode->i_mode)) { - error = -ENOTTY; - goto done; - } + if (!S_ISREG(inode->i_mode)) + break; error = put_user(i_size_read(inode) - filp->f_pos, p); goto done; } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |