lkml.org 
[lkml]   [2004]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Split bprm_apply_creds into two functions
From
Date
On Thu, 2004-12-16 at 13:16, Serge E. Hallyn wrote:
> As Stephen points out, it was more a concern about lock nesting. The
> attached patch simply removes the task_unlock from selinux_bprm_apply_creds,
> and runs just fine on my machine. Stephen, do you have a preference
> either way, or was the task_unlock to relieve the concerns of others?

I prefer your original patch (with the two minor changes I suggested),
to avoid unnecessary lock nesting.

--
Stephen Smalley <sds@epoch.ncsc.mil>
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.052 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site