lkml.org 
[lkml]   [2004]   [Dec]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromArnd Bergmann <>
SubjectRe: unregister_ioctl32_conversion and modules. ioctl32 revisited.
DateWed, 15 Dec 2004 14:46:01 +0100
On Middeweken 15 Dezember 2004 12:42, Michael S. Tsirkin wrote:
> +       /* The two calls ioctl_native and ioctl_compat described below
> +        * can be used as a replacement for the ioctl call above. They
> +        * take precedence over ioctl: thus if they are set, ioctl is
> +        * not used.  Unlike ioctl, BKL is not taken: drivers manage
> +        * their own locking. */

I don't really understand how this should deal with drivers that have
both generic and private ioctl conversion handlers. E.g. 
drivers/s390/block/dasd*.c want to go through the handlers in 
fs/compat_ioctl.c for stuff like BLKGETSIZE, while it also allows
third party modules to dynamically register additional ioctls.
See drivers/s390/block/dasd_cmb.c for an example, I think EMC are
doing something similar to support their drives.

If the dasd driver now implements an ioctl_compat() method, who will
call the standard conversion handlers?

 Arnd <><


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:08    [from the cache]
©2003-2008