lkml.org 
[lkml]   [2004]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kernel BUG at mm/rmap.c:480 in 2.6.10-rc3-bk7
On Wed, Dec 15, 2004 at 11:48:26PM +0100, Andrea Arcangeli wrote:
> On Wed, Dec 15, 2004 at 08:03:43PM +0100, Andrea Arcangeli wrote:
> > + if (page->mapping)
> > + page_remove_rmap(page);
>
> This had to be page_mapping, since I believe the page->mapping can go
> away with the truncate while the page is still being mapped.
>
> The rule is that if a page must not be accounted it will never be
> accounted and page_mapping will be always 0. If it has been accounted
> previously, then it must be unaccounted too. This worked fine so far.
>
> Plus I noticed other goodness that got dropped in the same area from my
> original 2.6.5 patches, and I resurrected those too in sync with SP1
> (I'm talking about the fork path).
>
> So here an updated patch, please give this one a spin.

No oops with this patch or odd messages in the syslog! It works fine
for me, thanks a lot.

I'll let the mm developers battle it out to determine if this is a good
fix or not :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [from the cache]
©2003-2011 Jasper Spaans