Messages in this thread | | | Date | Fri, 10 Dec 2004 08:36:14 -0800 | From | William Lee Irwin III <> | Subject | Re: [PATCH] oom killer (Core) |
| |
On Fri, Dec 03, 2004 at 03:28:54AM +0100, Andrea Arcangeli wrote: > + if (mm == &init_mm) { > + mmput(mm); > + return NULL; > + }
On Fri, Dec 03, 2004 at 03:28:54AM +0100, Andrea Arcangeli wrote: > + if (PTR_ERR(p) == -1UL) > + goto out; > + > /* Found nothing?!?! Either we hang forever, or we panic. */ > if (!p) { > + read_unlock(&tasklist_lock); > show_free_areas(); > panic("Out of memory and no killable processes...\n"); > }
Maybe the mm == &init_mm case should return an ERR_PTR also, as that is a sign of a transient error, not cause for a hard panic.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |