Messages in this thread |  | | | Date | Mon, 8 Nov 2004 23:14:56 -0800 | | From | Greg KH <> | | Subject | Re: 2.6.10-rc1-mm3 |
| |
On Mon, Nov 08, 2004 at 09:27:47PM -0800, Andrew Morton wrote: > Greg KH <greg@kroah.com> wrote: > > > > So I don't see how that could be failing here. And why I don't see this > > on my boxes... > > OK, progress. The oops is due to CONFIG_LEGACY_PTY_COUNT=512. I assume > anything greater than 256 will trigger it. > > - tty_register_driver() calls tty_register_device() for 512 devices. > > - tty_register_device() calls pty_line_name() for the 512 devices, but > pty_line_name() only understands 256 devices. After that, it starts > returning duplicated names. > > - class_simple_device_add() gets an -EEXIST return from > class_device_register() and then tries to kfree local variable s_dev, but > it's already free. Presumably all that icky refcounting under > class_device_register() did this for us already. Can you fix this one > Greg? Just enable slab debugging, set CONFIG_LEGACY_PTY_COUNT=512 and > watch the fun.
Ick, yeah, I just tested that. I don't know why that's happening, I'll go fix it up now.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |