Messages in this thread | | | Date | Tue, 9 Nov 2004 14:02:17 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 17/20] FRV: Better mmap support in uClinux |
| |
On Tue, Nov 09, 2004 at 01:55:26PM +0000, David Howells wrote: > > > > +/* list of shareable VMAs */ > > > +LIST_HEAD(nommu_vma_list); > > > +DECLARE_RWSEM(nommu_vma_sem); > > > > As I told you this absolutely should be static. > > Yes, you did. I ignored you. You also said that I shouldn't put any proc stuff > in mm/.
I didn't say you should put any proc stuff into mm/ but that's it propably more readablewhen kept in fs/proc/.
But again - global lists are really, really bad. If you want to access it add proper acessor functions.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |