lkml.org 
[lkml]   [2004]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb
    From
    Date
    On Mon, 2004-11-08 at 17:06 +0800, Antonino A. Daplas wrote:

    >
    > How about this patch? This is almost the original macro in riva_hw.h,
    > with the __force annotation.

    I don't like it neither. It lacks barriers. the rivafb driver
    notoriously lacks barriers, except in a few places where it was so bad
    that it actually broke all the time, where we added some. This
    originates from the X "nv" driver written by Mark Vojkovich who didn't
    want to hear about barriers for perfs reasons I think.

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.041 / U:0.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site