Messages in this thread | | | Date | Mon, 8 Nov 2004 09:11:45 -0800 | From | Chris Wright <> | Subject | Re: [PATCH][OPROFILE] disable preempt when calling smp_processor_id() |
| |
* John Levon (levon@movementarian.org) wrote: > On Fri, Nov 05, 2004 at 04:32:21PM -0800, Chris Wright wrote: > > smp_processor_id() is called w/out preempt disabled. Use > > get_cpu()/put_cpu() instead. Should this be put_cpu_no_resched()? > > No, the patch below looks fine
I realized over the weekend that it's still broken. And Cliff hit it in some tests he ran here. The sync_buffer() function can sleep, and while the unprotected call to smp_processor_id() is no longer a problem, scheduling with preempt disabled is.
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |