lkml.org 
[lkml]   [2004]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] small input cleanup
On Sat, Nov 06, 2004 at 10:49:54PM -0500, Dmitry Torokhov wrote:

> Hi,

Hi Dmitry,

> On Saturday 06 November 2004 10:12 pm, Adrian Bunk wrote:
> > The patch below does the following cleanups under drivers/input/ :
> > - make some needlessly global code static
> > - remove the completely unused EXPORT_SYMBOL'ed function gameport_rescan
>
> It will be used (but in some transformed) once I finish gameport sysfs
> support, but it probably need not be exported.
>
> > - make the EXPORT_SYMBOL'ed function ps2_sendbyte static since it isn't
> >   used outside the file where it's defined
>
> libps2 is a library for communicating with standard PS/2 device and while
> the function is not currently used it is part of the interface. I would
> like to leave the function as is.

my personal opinions:
- if gameport_rescan will not be needed in it's current form, there's
no need for it (you can always add the "real" function when it's
required
- could ps2_sendbyte be #ifdef 0'ed until it's required?
this way, it wouldn't make the kernel bigger today

> Dmitry

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.040 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site