lkml.org 
[lkml]   [2004]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Remove OOM killer from try_to_free_pages / all_unreclaimable braindamage


    Hugh Dickins wrote:

    >On Sat, 6 Nov 2004, Andrea Arcangeli wrote:
    >
    >>all allocations should have a failure path to avoid deadlocks. But in
    >>the meantime __GFP_REPEAT is at least localizing the problematic places ;)
    >>
    >
    >Problematic, yes: don't overlook that GFP_REPEAT and GFP_NOFAIL _can_
    >fail, returning NULL: when the process is being OOM-killed (PF_MEMDIE).
    >
    >

    Yeah right you are. I think NOFAIL is a bug and should really not fail.
    It looks like it is only used in fs/jbd/*, and things will crash if it
    fails. Maybe they're only called from the kjournald threads and can't
    be OOM killed, but that is still a pretty subtle dependancy.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.023 / U:30.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site