Messages in this thread | | | Date | Sat, 6 Nov 2004 18:45:55 +0000 | From | Matthew Wilcox <> | Subject | Re: Kernel 2.6.x hangs with Symbios Logic 53c1010 Ultra3 SCSI Ada pter |
| |
On Sat, Nov 06, 2004 at 12:03:58PM +0000, Christoph Hellwig wrote: > On Sat, Nov 06, 2004 at 03:59:51AM +0000, Matthew Wilcox wrote: > > On Sat, Nov 06, 2004 at 12:02:32AM -0000, Richard Waltham wrote: > > > Good as a backup but the original PPR capability is defined in > > > scan_scsi.c. Shouldn't scan_scsi.c take note of the bus mode and enable > > > PPR capabilities accordingly? This would then cover this issue for all > > > relevant LLDDs wouldn't it? > > > > scan_scsi.c doesn't know what mode the bus is in. scan_scsi.c doesn't > > even know whether the bus is SPI, FC, iSCSI, SAS or SATA. > > And PPR only makes sense for SPI anyway. An good argument why this > should move to the SPI transport class, which does know about SE vs HVD > vs LVD.
That would make sense if more of this were done at a higher level. As it is right now, the decision whether to use PPR, SDTR or WDTR is entirely up to the driver. I think there's a lot more consolidation that could be done into the midlayer, but we should probably see what other drivers requirements are before making it perfect for sym2.
-- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |