lkml.org 
[lkml]   [2004]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: breakage: flex mmap patch for x86-64
    Date
    On Friday 05 of November 2004 23:24, Ricky Beam wrote:
    > ChangeSet Key: 4188122b4-5vHFkvfD5Pc0Egjyaz8w
    >
    > ======== ChangeSet 1.2424.7.12 ========
    > D 1.2424.7.12 04/11/02 15:03:07-08:00 ak@suse.de[torvalds] 53848 53847 3/0/1
    > P ChangeSet
    > C [PATCH] x86_64: flex mmap patch for x86-64
    > C
    > C From: Arjan van de Ven <arjanv@redhat.com>
    > C
    > C Do flex mmap for x86-64. mmaps will grow down in the address space now
    > C instead of up.
    > C
    > C Patch has 2 parts; the generic strategy selection, and code to make a
    correct
    > C TASK_SIZE . the later may be fixed in your tree already in which case
    it's
    > C redundant.
    > C
    > C Modified by AK to apply to 64bit processes too.
    > C
    > C Signed-off-by: Andrew Morton <akpm@osdl.org>
    > C Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    > ------------------------------------------------
    >
    > This prevents 32bit apps from running on x86_64. Backing out the Makefile
    > and processor.h changes has everything working again. Perhaps something
    > needs to check for a 32bit environment? I don't know if it's the change
    > to TASK_SIZE or the "backwards" mmaps that's the real breakage. And at this
    > point, I don't have time to test.
    >
    > (64bit apps work just fine.)

    Confirmed, and apparently it is not sifficient to change the TASK_SIZE
    definition in include/asm-x86_64/processor.h to make the 32-bit userland
    work. Hence, it seems that the "backwards" mmaps break things.

    Greets,
    RJW

    --
    - Would you tell me, please, which way I ought to go from here?
    - That depends a good deal on where you want to get to.
    -- Lewis Carroll "Alice's Adventures in Wonderland"
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:3.284 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site