Messages in this thread | | | Subject | RE: patch for sysfs in the cyclades driver | Date | Thu, 4 Nov 2004 11:50:55 -0600 | From | "Kilau, Scott" <> |
| |
> > and the implementation in in drivers/scsi/st.c, that there's no > > problem adding attributes to a device in a simple class. You can just > > use class_set_devdata() on your class_device to set whatever context > > you need to get back to your internal structures, and then use > > class_device_create_file() to add the attributes. > > > > I assume this is OK (since there is already one in-kernel driver doing > > it), but Greg, can you confirm that it's definitely OK for a driver to > > use class_set_devdata() on a class_device from class_simple_device_add()?
> Hm, I think that should be ok, but I'd make sure to test it before > verifying that it really is :)
I have just added this code and tested it, and indeed it *does* work!
So I will graciously redraw my comments from my previous email. It works, and this is definitely the way Germano and I should go in each of our respective drivers.
Thanks again for everyones comments/help!
Scott Kilau Digi International
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |