Messages in this thread | | | Date | Thu, 4 Nov 2004 09:40:44 -0800 | From | Greg KH <> | Subject | Re: patch for sysfs in the cyclades driver |
| |
On Thu, Nov 04, 2004 at 08:58:21AM -0800, Roland Dreier wrote: > Marcelo> The problem was class_simple only contains the "dev" > Marcelo> attribute. You can't add other attributes to it. > > I believe, based on the comment in class_simple.c: > > Any further sysfs files that might be required can be created using this pointer. > > and the implementation in in drivers/scsi/st.c, that there's no > problem adding attributes to a device in a simple class. You can just > use class_set_devdata() on your class_device to set whatever context > you need to get back to your internal structures, and then use > class_device_create_file() to add the attributes. > > I assume this is OK (since there is already one in-kernel driver doing > it), but Greg, can you confirm that it's definitely OK for a driver to > use class_set_devdata() on a class_device from class_simple_device_add()?
Hm, I think that should be ok, but I'd make sure to test it before verifying that it really is :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |