Messages in this thread Patch in this message |  | | | Subject | [patch 11/20] uml: remove SIGPROF from change_signals | | From | blaisorblade_spam@yahoo ... | | Date | Thu, 04 Nov 2004 00:17:40 +0100 |
| |
From: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>, Jeff Dike <jdike@addtoit.com>
Since local_irq_save() and local_irq_disable() should match (apart from saving the flags), get/set_signals must match [un]block_signals, i.e. change_signals; since get/set_signals don't enable/disable SIGPROF (and this behaviour is safe as explained in the comment the patch adds, since the profiling code does not interact with the kernel code), not even change_signals must toggle it.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it> --- vanilla-linux-2.6.9-paolo/arch/um/kernel/signal_user.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletion(-) diff -puN arch/um/kernel/signal_user.c~uml-remove-SIGPROF-change_signals arch/um/kernel/signal_user.c --- vanilla-linux-2.6.9/arch/um/kernel/signal_user.c~uml-remove-SIGPROF-change_signals 2004-11-03 23:44:59.984441096 +0100 +++ vanilla-linux-2.6.9-paolo/arch/um/kernel/signal_user.c 2004-11-03 23:44:59.986440792 +0100 @@ -57,6 +57,10 @@ int change_sig(int signal, int on) return(!sigismember(&old, signal)); } +/* Both here and in set/get_signal we don't touch SIGPROF, because we must not + * disable profiling; it's safe because the profiling code does not interact + * with the kernel code at all.*/ + static void change_signals(int type) { sigset_t mask; @@ -65,7 +69,6 @@ static void change_signals(int type) sigaddset(&mask, SIGVTALRM); sigaddset(&mask, SIGALRM); sigaddset(&mask, SIGIO); - sigaddset(&mask, SIGPROF); if(sigprocmask(type, &mask, NULL) < 0) panic("Failed to change signal mask - errno = %d", errno); } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |