lkml.org 
[lkml]   [2004]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: ds1620: replace schedule_timeout() with msleep()
    On 28/11/04 18:39 +0100, Jesper Juhl wrote:
    > > +++ linux-2.6.9-rc1-bk7-max/drivers/char/ds1620.c 2004-09-01 19:34:43.000000000 +0200
    > > @@ -373,8 +373,7 @@ static int __init ds1620_init(void)
    > > th_start.hi = 1;
    > > ds1620_write_state(&th_start);
    > >
    > > - set_current_state(TASK_INTERRUPTIBLE);
    > > - schedule_timeout(2*HZ);
    > > + msleep(2000);
    > >
    > > ds1620_write_state(&th);
    > >
    > I'm wondering if 2000 is really the value we want here. As far as I can
    > see, the schedule_timeout(2*HZ); line has been there as long back as
    > since HZ was 100, so back then the delay would have been 200. if 200 is
    > all it needs, then we are now sleeping 10 times as long as really needed.
    > What is the argument behind the value used?

    It's right:
    schedule_timeout(2*HZ) sleeps for 2 seconds;
    msleep(2000) sleeps for 2000 miliseconds, and does not depend on what
    HZ is.


    Domen
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:6.362 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site