Messages in this thread | | | Date | Mon, 29 Nov 2004 16:06:48 -0800 | From | Greg KH <> | Subject | Re: [2.6 PATCH] visor: Make URB limit error more visible |
| |
On Sun, Nov 28, 2004 at 05:11:25PM +0000, Alan Cox wrote: > On Iau, 2004-11-25 at 16:16, Roger Luethi wrote: > > There is only one call to dev_dbg in all of visor.c, the rest is dbg or > > dev_err. It already bit us once when warnings didn't turn up in a debug > > log. I would argue that a flood of those warnings will warrant report > > and inspection anyway (broken app, broken driver, or lame DoS attempt), > > so I replaced the dev_dbg with dev_err. > > > > Signed-off-by: Roger Luethi <rl@hellgate.ch> > > Since it is trivially user caused should it not be rate limited or it > becomes a DoS of its own to the syslog
Agreed, that's why the change I commited doesn't do it this way :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |