Messages in this thread Patch in this message | | | Date | Thu, 25 Nov 2004 17:16:19 +0100 | From | Roger Luethi <> | Subject | [2.6 PATCH] visor: Make URB limit error more visible |
| |
There is only one call to dev_dbg in all of visor.c, the rest is dbg or dev_err. It already bit us once when warnings didn't turn up in a debug log. I would argue that a flood of those warnings will warrant report and inspection anyway (broken app, broken driver, or lame DoS attempt), so I replaced the dev_dbg with dev_err.
Signed-off-by: Roger Luethi <rl@hellgate.ch>
--- linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c.orig 2004-11-25 17:03:18.056410624 +0100 +++ linux-2.6.10-rc2-bk8/drivers/usb/serial/visor.c 2004-11-25 17:05:04.113287528 +0100 @@ -494,7 +494,7 @@ static int visor_write (struct usb_seria spin_lock_irqsave(&priv->lock, flags); if (priv->outstanding_urbs > URB_UPPER_LIMIT) { spin_unlock_irqrestore(&priv->lock, flags); - dev_dbg(&port->dev, "write limit hit\n"); + dev_err(&port->dev, "write limit hit\n"); return 0; } spin_unlock_irqrestore(&priv->lock, flags); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |