Messages in this thread | | | Date | Fri, 26 Nov 2004 01:05:02 +0100 | From | Pavel Machek <> | Subject | Re: Suspend 2 merge: 21/51: Refrigerator upgrade. |
| |
Hi!
> > > > Silently doing nothing when user asked for sync is not nice, > > > > either. BUG() is better solution than that. > > > > > > I don't think we should BUG because the user presses Sys-Rq S while > > > suspending. I'll make it BUG_ON() and make the Sys_Rq printk & ignore > > > when suspending. Sound reasonable? > > > > Yes, that's better. ... only that it means just another hook somewhere > > :-(. > > :<. But we're only talking two or three lines. Let's keep it in > perspective.
I think even three lines are bad. It means that swsusp is no longer self-contained subsystem, but that it has its hooks all over the place. And those hooks need to be maintained, too. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |