lkml.org 
[lkml]   [2004]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Suspend 2 merge: 21/51: Refrigerator upgrade.
    Hi!

    > Included in this patch is a new try_to_freeze() macro Andrew M suggested
    > a while back. The refrigerator declarations are put in sched.h to save
    > extra includes of suspend.h.

    try_to_freeze looks nice. Could we get it in after 2.6.10 opens?

    > +++ 582-refrigerator-new/drivers/pnp/pnpbios/core.c 2004-11-24 17:58:33.769748640 +1100
    > @@ -179,6 +179,10 @@
    > * Poll every 2 seconds
    > */
    > msleep_interruptible(2000);
    > +
    > + if(current->flags & PF_FREEZE)
    > + refrigerator(PF_FREEZE);
    > +
    > if(signal_pending(current))
    > break;
    >

    Use new interface here?

    > */
    > int fsync_super(struct super_block *sb)
    > {
    > + int ret;
    > +
    > + /* A safety net. During suspend, we might overwrite
    > + * memory containing filesystem info. We don't then
    > + * want to sync it to disk. */
    > + if (unlikely(test_suspend_state(SUSPEND_DISABLE_SYNCING)))
    > + return 0;
    > +

    If it is safety net, do BUG_ON().
    Pavel
    --
    64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:4.031 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site