lkml.org 
[lkml]   [2004]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [linux-usb-devel] [PATCH] Ohci-hcd: fix endless loop
    On 26 Nov 2004 at 08h11, David Brownell wrote:

    Hi,

    > The infinite loop means that something trashed the stack, yes?
    >
    > The "limit-- < -1000" test below should never be able to succeed
    > unless the previous "limit-- == 0" test got trashed by having
    > something obliterate the stack.

    Sure? the (limit -- == 0) gotoes higher to test again.
    from what I understand the loop goes back to rescan 1000 times, then once
    to sanitize, then to back to rescan again infinetely...
    I may be wrong but I don't think there's a stack corruption there.

    > If you got the "IRQ INTR_SF lossage" diagnostic, there's clearly
    > some problem with IRQ handling after the resume ... is the iBook
    > firmware (or hardware) doing wierd stuff so that the normal PCI
    > IRQ calls stopped working?

    No, the rest of the computer worked fine.

    > And for that matter, "limit" is unsigned, so you must be getting
    > (and ignoring) some compiler warnings too.

    Yes, noticed and sent a second patch.

    --
    Colin
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:5.842 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site