lkml.org 
[lkml]   [2004]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kill the last few warnings in binfmt_elf.c

Hi Andrew,

On Wed, 3 Nov 2004, Jesper Juhl wrote:

> On Tue, 2 Nov 2004, Andrew Morton wrote:
>
[...]
> > The other patches are still queued up in my todo queue. This is because I
> > took a close look at these warnings some weeks ago and ended up deciding
> > that the proper fixes were complex and risky. So I need to go through your
> > patches with some care. I hope you've already done so.
> >
> I've certainly tried, but as I'm sure you are aware I have nowhere near
> the level of experience of most people on the list, but I've tried my best
> to ensure that these patches do the right thing, and I've been using them
> on my own box ever since making the first one and I've not seen any ill
> effects yet.
>
> Now that you say the proper fixes are probably "complex and risky" I think
> I'll go back and double check my changes once more this evening. I
> certainly don't want to waste your time with silly errors I could find
> myself.
>
I've been looking over my patches again (and still doing so), and I must
say that I feel quite comfortable with my changes related to padzero() - I
think at least that bit could go into -mm for now. I'm also quite certain
my change to fill_psinfo() is safe (although I know you consider it a
silly fix), that could probably also safely go into -mm. The rest of the
changes have not caused me any trouble, but I don't have as warm and fuzzy
a feeling in my belly about those as I do about the padzero() and
fill_psinfo() changes, so the rest should probably wait a bit unless your
reading of them tells you they are correct - I'll keep
digging/reading/learning and see if I can either confirm the rest is OK or
find the proper solution, but that could take a while...

--
Jesper Juhl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.066 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site