Messages in this thread | | | Date | Wed, 24 Nov 2004 16:41:41 +0200 | From | "O.Sezer" <> | Subject | Re: status of cdrom patches for 2.4 ? |
| |
Jens Axboe wrote: > On Wed, Nov 24 2004, Marcelo Tosatti wrote: > >>On Wed, Nov 24, 2004 at 01:11:13AM +0200, O.Sezer wrote: >> >>>Hi all: >>> >>>What are the status of the cdrom patches for 2.4 series? >>>Namely the dvd patches which are dropped while in the >>>27-rc era, and the cd-mrw patch which never had a chance >>>trying to go in to 2.4. Jens? Mancelo? >> >>There were problems with the DVD-RW patches so I reverted them.
Yup. Pat then posted a patch which supposedly fixed it by placing something like else if (CDROM_CAN(CDC_DVD_RAM)) ret = 0; in cdrom_open_write(): http://marc.theaimsgroup.com/?t=109156838400001&r=1&w=2 http://marc.theaimsgroup.com/?l=linux-scsi&m=109156820507518&w=2
Jens' MRW patch also introduces a new function: cdrom_dvdram_open_write (which, in turn, calls cdrom_media_erasable), CDROM_CAN(CDC_DVD_RAM) check in cdrom_open_write() is assigned to it; which again is supposed to fix it.
>>Jens, what do you think? > > > I don't think it's worth the bother, the support is in 2.6. And I don't > want to maintain new atapi stuff for 2.4. Pat used to care about the > patches, but as he is no longer with Iomega I don't think there's anyone > to look after it.
Which is truly a pity. Yes I can understand that a maintainer needs to concentrate on new trees etc, but it's pity. Especially hearing the pre-recorded "Hey 2.6 already has it, upgrade to it" message is always nice ;)
Ozkan Sezer
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |