lkml.org 
[lkml]   [2004]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] let fat handle MS_SYNCHRONOUS flag
    On Thu, Nov 18, 2004 at 07:49:59PM +0100, Colin Leroy wrote:
    > Hi,
    >
    > this patch is an RFC patch not to be applied.
    > It adds MS_SYNCHRONOUS support to FAT filesystem, so that less
    > filesystem breakage happen when disconnecting an USB key, for
    > example. I'd like to have comments about it, because as it
    > seems to work fine here, I'm not used to fs drivers and could
    > have made mistakes.
    > Thanks,
    >
    > + if (bh != NULL) {
    > + sync_dirty_buffer(bh);
    > + brelse(bh);
    > + } else {
    > + BUG_ON(1);

    This construct is really weird.

    How about:

    BUG_ON(!bh);
    sync_dirty_buffer(bh);
    brelse(bh);

    Concept seems good, and the implementation otherwise looks good at
    first glance.

    --
    Mathematics is the supreme nostalgia of our time.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:08    [W:0.022 / U:29.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site